Commit f5ada392 authored by Cédric OLIVIER's avatar Cédric OLIVIER
Browse files

feat: Change boolean variable behaviour 



BREAKING CHANGE: boolean variable now triggered on explicit 'true' value

Signed-off-by: default avatarCédric OLIVIER <cedric3.olivier@orange.com>
parent dacac199

README.md

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ It uses the following variable: 
| `TESTSSL_IMAGE` | The Docker image used to run [Test SSL](https://testssl.sh/) | `drwetter/testssl.sh:latest` |

| `TESTSSL_ARGS`  | Test SSL [command-line options](https://testssl.sh/#usage)   | `--severity MEDIUM` |

| `TESTSSL_URL`   | Server url to test TLS/SSL against       | _none_ (auto evaluated: see below) |

| `REVIEW_ENABLED`| Set to enable Test SSL tests on review environments (dynamic environments instantiated on development branches) | _none_ (disabled) |

| `REVIEW_ENABLED`| Set to `true` to enable Test SSL tests on review environments (dynamic environments instantiated on development branches) | _none_ (disabled) |



### test url auto evaluation

templates/gitlab-ci-testssl.yml

+2 −2
Original line number Diff line number Diff line
@@ -198,7 +198,7 @@ stages: 
    fi

  }



  if [[ -z "$TEMPLATE_CHECK_UPDATE_DISABLED" ]]; then check_for_update testssl "1.2.0"; fi

  if [[ "$TEMPLATE_CHECK_UPDATE_DISABLED" != "true" ]]; then check_for_update testssl "1.2.0"; fi

  unscope_variables



  # ENDSCRIPT
@@ -240,6 +240,6 @@ testssl: 
    # on production and integration branch(es): auto (on_success)

    - if: '$CI_COMMIT_REF_NAME =~ $PROD_REF || $CI_COMMIT_REF_NAME =~ $INTEG_REF'

    # on other branch(es): manual & non-blocking if $REVIEW_ENABLED set

    - if: $REVIEW_ENABLED

    - if: '$REVIEW_ENABLED == "true"'

      when: manual

      allow_failure: true