Commit 2638d72a authored by Pierre SMEYERS's avatar Pierre SMEYERS
Browse files

Merge branch '1-change_variable_behaviour' into 'master' 

feat: Change boolean variable behaviour

Closes #1

See merge request to-be-continuous/puppeteer!1
parents 9712f2e6 996418b8

README.md

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ It uses the following variable: 
| `PUPPETEER_IMAGE`     | The Docker image used to run [Puppeteer](https://hub.docker.com/r/buildkite/puppeteer) | `buildkite/puppeteer:latest` |

| `PUPPETEER_PROJECT_DIR` | The Puppeteer project directory (containing `package.json`) | `.` |

| `PUPPETEER_TEST_EXTRA_ARGS`  | Testing framework extra options based on [Jest](https://jestjs.io/docs/en/cli) | _none_ |

| `REVIEW_ENABLED`      | Set to enable Puppeteer tests on review environments (dynamic environments instantiated on development branches) | _none_ (disabled) |

| `REVIEW_ENABLED`      | Set to `true` to enable Puppeteer tests on review environments (dynamic environments instantiated on development branches) | _none_ (disabled) |



### Unit tests report integration

templates/gitlab-ci-puppeteer.yml

+2 −2
Original line number Diff line number Diff line
@@ -200,7 +200,7 @@ stages: 
    fi

  }



  if [[ -z "$TEMPLATE_CHECK_UPDATE_DISABLED" ]]; then check_for_update puppeteer "1.2.0"; fi

  if [[ "$TEMPLATE_CHECK_UPDATE_DISABLED" != "true" ]]; then check_for_update puppeteer "1.2.0"; fi

  unscope_variables



  # ENDSCRIPT
@@ -255,6 +255,6 @@ puppeteer: 
    # on production and integration branch(es): auto (on_success)

    - if: '$CI_COMMIT_REF_NAME =~ $PROD_REF || $CI_COMMIT_REF_NAME =~ $INTEG_REF'

    # on other branch(es): manual & non-blocking if $REVIEW_ENABLED set

    - if: $REVIEW_ENABLED

    - if: '$REVIEW_ENABLED == "true"'

      when: manual

      allow_failure: true