Commit 3d9fb3c2 authored by Cédric OLIVIER's avatar Cédric OLIVIER
Browse files

feat: Change boolean variable behaviour 



BREAKING CHANGE: boolean variable now triggered on explicit 'true' value

Signed-off-by: default avatarCédric OLIVIER <cedric3.olivier@orange.com>
parent 7f16985e

README.md

+2 −2
Original line number Diff line number Diff line
@@ -67,7 +67,7 @@ It uses the following variable: 
| Name                  | description                              | default value     |

| --------------------- | ---------------------------------------- | ----------------- |

| `PHP_UNIT_ARGS`       | Additional PHPUnit [options](https://phpunit.readthedocs.io/en/latest/textui.html#command-line-options) | _none_ |

| `PHP_UNIT_DISABLED`   | Set to disable PHPUnit test (if some `phpunit.xml` or `phpunit.xml.dist` file unintentionally triggers the build) | _none_ (auto based on presence of `phpunit.xml` or `phpunit.xml.dist` file) |

| `PHP_UNIT_DISABLED`   | Set to `true` to disable PHPUnit test (if some `phpunit.xml` or `phpunit.xml.dist` file unintentionally triggers the build) | _none_ (auto based on presence of `phpunit.xml` or `phpunit.xml.dist` file) |



This job:
@@ -87,7 +87,7 @@ It uses the following variable: 


| Name                       | description                              | default value     |

| -------------------------- | ---------------------------------------- | ----------------- |

| `PHP_CODESNIFFER_DISABLED` | Set to disable this job                  | _none_ (enabled)  |

| `PHP_CODESNIFFER_DISABLED` | Set to `true` to disable this job                  | _none_ (enabled)  |

| `PHP_CODESNIFFER_ARGS`     | PHP_CodeSniffer [options](https://github.com/squizlabs/PHP_CodeSniffer/wiki/Configuration-Options) | `--report-summary --report-checkstyle=reports/phpcs-checkstyle.xml --report-code=reports/phpcs-code.txt` |



You have two options to configure PHP_CodeSniffer for your project:

templates/gitlab-ci-php.yml

+2 −2
Original line number Diff line number Diff line
@@ -232,7 +232,7 @@ stages: 
    fi

  }



  if [[ -z "$TEMPLATE_CHECK_UPDATE_DISABLED" ]]; then check_for_update php "1.2.1"; fi

  if [[ "$TEMPLATE_CHECK_UPDATE_DISABLED" != "true" ]]; then check_for_update php "1.2.1"; fi

  unscope_variables



  # ENDSCRIPT
@@ -321,7 +321,7 @@ php-codesniffer: 
    - if: $CI_MERGE_REQUEST_ID

      when: never

    # exclude if $PHP_CODESNIFFER_DISABLED not set

    - if: $PHP_CODESNIFFER_DISABLED

    - if: '$PHP_CODESNIFFER_DISABLED == "true"'

      when: never

    # on tags: auto

    - if: $CI_COMMIT_TAG