Commit eee6b1ad authored by Pierre Smeyers's avatar Pierre Smeyers
Browse files

fix(lint): '--' no longer required with Yarn 4 to distinguish its own args from script args

parent 3a694de2

templates/gitlab-ci-node.yml

+8 −6
Original line number Diff line number Diff line
@@ -757,10 +757,11 @@ node-lint: 
        # generate eslint report for SonarQube

        # shellcheck disable=SC2086

        log_info "SonarQube detected: producing ESLint JSON report..."

        if [ "$NODE_MANAGER" = "pnpm" ] || [ "$NODE_MANAGER" = "bun" ]; then

          $NODE_MANAGER $NODE_LINT_ARGS --format=json --output-file=reports/node-lint.xslint.json || true

        else

        if [ "$NODE_MANAGER" = "npm" ]; then

          # only npm requires '--' to distinguish its own args from script args

          $NODE_MANAGER $NODE_LINT_ARGS -- --format=json --output-file=reports/node-lint.xslint.json || true

        else

          $NODE_MANAGER $NODE_LINT_ARGS --format=json --output-file=reports/node-lint.xslint.json || true

        fi

      fi

    # maybe add eslint-formatter-gitlab
@@ -773,10 +774,11 @@ node-lint: 
    # run ESLint with console output and GitLab report

    # shellcheck disable=SC2086

    - |

      if [ "$NODE_MANAGER" = "pnpm" ] || [ "$NODE_MANAGER" = "bun" ]; then

        ESLINT_CODE_QUALITY_REPORT=reports/node-lint.gitlab.json $NODE_MANAGER $NODE_LINT_ARGS --format=gitlab

      else

      if [ "$NODE_MANAGER" = "npm" ]; then

        # only npm requires '--' to distinguish its own args from script args

        ESLINT_CODE_QUALITY_REPORT=reports/node-lint.gitlab.json $NODE_MANAGER $NODE_LINT_ARGS -- --format=gitlab

      else

        ESLINT_CODE_QUALITY_REPORT=reports/node-lint.gitlab.json $NODE_MANAGER $NODE_LINT_ARGS --format=gitlab

      fi

  artifacts:

    when: always # store artifact even if test Failed