Commit 584e8801 authored by Mathis Goichon's avatar Mathis Goichon
Browse files

fix(node-build): remove --bail option from NODE_TEST_ARGS default value 



Signed-off-by: default avatarMathis Goichon <mathisgoichon@gmail.com>
parent e43446a3

README.md

+6 −6
Original line number Diff line number Diff line
@@ -54,11 +54,11 @@ for jobs dependency reasons (some jobs such as SONAR analysis have a dependency 
This job is bound to the `build` stage, and uses the following variables:



| Name                          | description                                                                                                                                                       | default value         |

|-------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------------|

|-------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------------|

| `NODE_BUILD_DISABLED`         | Set to `true` to disable build                                                                                                                                    | _none_ (enabled)      |

| `NODE_BUILD_DIR`              | Variable to define build directory                                                                                                                                | `dist`                |

| `NODE_BUILD_ARGS`             | npm [run script](https://docs.npmjs.com/cli/v8/commands/npm-run-script) arguments <br/> yarn [run script](https://classic.yarnpkg.com/en/docs/cli/run) arguments  | `run build --prod`    |

| `NODE_TEST_ARGS`              | npm [test](https://docs.npmjs.com/cli/v8/commands/npm-test) arguments <br/> yarn [test](https://classic.yarnpkg.com/en/docs/cli/test) arguments                   | `test -- --coverage --bail`     |

| `NODE_TEST_ARGS`              | npm [test](https://docs.npmjs.com/cli/v8/commands/npm-test) arguments <br/> yarn [test](https://classic.yarnpkg.com/en/docs/cli/test) arguments                   | `test -- --coverage`  |



The job generates a unit test report that you will find here: `NODE_PROJECT_DIR/reports/junit_test_report.xml`.

kicker.json

+1 −1
Original line number Diff line number Diff line
@@ -48,7 +48,7 @@ 
    {

      "name": "NODE_TEST_ARGS",

      "description": "npm [test](https://docs.npmjs.com/cli/v8/commands/npm-test) arguments - yarn [test](https://classic.yarnpkg.com/en/docs/cli/test) arguments",

      "default": "test -- --coverage --bail",

      "default": "test -- --coverage",

      "advanced": true

    }

  ],

templates/gitlab-ci-node.yml

+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ variables: 
  # Node build

  NODE_BUILD_ARGS: "run build --prod"

  # Node test

  NODE_TEST_ARGS: "test -- --coverage --bail"

  NODE_TEST_ARGS: "test -- --coverage"



  # Audit

  NODE_AUDIT_LEVEL: "low"