Commit 46b049be authored by Mathis Goichon's avatar Mathis Goichon
Browse files

fix(node-outdated): remove silent parameter (bad practice) 



Signed-off-by: default avatarMathis Goichon <mathisgoichon@gmail.com>
parent 7270fd3e

README.md

+0 −1
Original line number Diff line number Diff line
@@ -255,7 +255,6 @@ It is bound to the `test` stage. 
| Name                      | description                                                                                                                                                           | default value                      |

|---------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------|

| `NODE_OUTDATED_DISABLED`  | Set to `true` to disable npm outdated                                                                                                                                 | _none_ (enabled)                   |

| `NODE_OUTDATED_SILENT`    | Set to `false` to enable job fails when dependencies are not up to date                                                                                               | `true`                             |

| `NODE_OUTDATED_ARGS`      | npm [outdated](https://docs.npmjs.com/cli/v8/commands/npm-outdated) arguments <br/> yarn [outdated](https://classic.yarnpkg.com/lang/en/docs/cli/outdated/) arguments | `--long`                           |

| `NODE_OUTDATED_JSON_PATH` | JSON outdated report path                                                                                                                                             | `reports/npm-outdated-report.json` |

kicker.json

+0 −5
Original line number Diff line number Diff line
@@ -104,11 +104,6 @@ 
      "description": "node outdated analysis",

      "disable_with": "NODE_OUTDATED_DISABLED",

      "variables": [

        {

          "name": "NODE_OUTDATED_SILENT",

          "description": "Set to `false` to enable job fails when dependencies are not up to date",

          "default": "true"

        },

        {

          "name": "NODE_OUTDATED_ARGS",

          "description": "npm [outdated](https://docs.npmjs.com/cli/v8/commands/npm-outdated) arguments - yarn [outdated](https://classic.yarnpkg.com/lang/en/docs/cli/outdated/) arguments",

templates/gitlab-ci-node.yml

+1 −4
Original line number Diff line number Diff line
@@ -52,7 +52,6 @@ variables: 


  # Outdated

  NODE_OUTDATED_ARGS: "--long"

  NODE_OUTDATED_SILENT: "true"

  NODE_OUTDATED_JSON_PATH: "reports/outdated-report.json"



  # default production ref name (pattern)
@@ -372,11 +371,9 @@ node-outdated: 
  extends: .node-base

  stage: test

  script:

    - set +e

    - mkdir -p reports

    - $NODE_MANAGER outdated --json $NODE_OUTDATED_ARGS > $NODE_OUTDATED_JSON_PATH

    - $NODE_MANAGER outdated $NODE_OUTDATED_ARGS || EXIT_CODE=$?

    - if [[ $NODE_OUTDATED_SILENT == "true" ]] && [[ $EXIT_CODE == 1 ]]; then exit 0; fi

    - $NODE_MANAGER outdated $NODE_OUTDATED_ARGS

  artifacts:

    name: "$CI_JOB_NAME artifacts from $CI_PROJECT_NAME on $CI_COMMIT_REF_SLUG"

    expire_in: 1 day