Commit 429b0058 authored by Bertrand Goareguer's avatar Bertrand Goareguer
Browse files

fix: atomic flag is deprecated 

Since Helm 4 the `--atomic` flag is deprecated, the template now uses `--rollback-on-failure` instead. If still using Helm 3, set `deploy-args` component input to `upgrade --install --atomic --timeout 120s`
parent b48c2ae5

README.md

+1 −1
Original line number Diff line number Diff line
@@ -320,7 +320,7 @@ The Helm template uses some global configuration used throughout all jobs. 
| `kube-namespace` / `KUBE_NAMESPACE` | The default Kubernetes namespace to use | _none_ but this variable is automatically set by [GitLab Kubernetes integration](https://docs.gitlab.com/user/project/clusters/) when enabled |

| `KUBE_CONTEXT`      | Defines the context to be used in `KUBECONFIG`. When using [GitLab agents with the CI/CD workflow](https://docs.gitlab.com/user/clusters/agent/ci_cd_workflow/), the value should be like `path/to/agent/project:agent-name`. To use different agents per environment, define an [environment-scoped CI/CD variable](https://docs.gitlab.com/ci/environments/#limit-the-environment-scope-of-a-cicd-variable) for each agent. | `$HELM_KUBECONTEXT` |

| :lock: `HELM_DEFAULT_KUBE_CONFIG` | The default kubeconfig to use (either content or file variable) | `$KUBECONFIG` (thus supports the [GitLab Kubernetes integration](https://docs.gitlab.com/user/project/clusters/) when enabled) |

| `deploy-args` / `HELM_DEPLOY_ARGS` | The Helm [command with options](https://helm.sh/docs/helm/helm_upgrade/) to deploy the application (_without dynamic arguments such as release name and chart_) | `upgrade --install --atomic --timeout 120s` |

| `deploy-args` / `HELM_DEPLOY_ARGS` | The Helm [command with options](https://helm.sh/docs/helm/helm_upgrade/) to deploy the application (_without dynamic arguments such as release name and chart_) | `upgrade --install --rollback-on-failure --timeout 120s` |

| `delete-args` / `HELM_DELETE_ARGS` | The Helm [command with options](https://helm.sh/docs/helm/helm_uninstall/) to cleanup the application (_without dynamic arguments such as release name_) | `uninstall` |

| `deploy-chart` / `HELM_DEPLOY_CHART` | The Helm [chart](https://helm.sh/docs/topics/charts/) to deploy. _Only required if you want to deploy an **external** chart._  | _none_ |

| `repos` / `HELM_REPOS` | The Helm [chart repositories](https://helm.sh/docs/topics/chart_repository/) to use (formatted as `repo_name_1@repo_url_1 repo_name_2@repo_url_2 ...`) | `stable@https://charts.helm.sh/stable bitnami@https://charts.bitnami.com/bitnami` |

kicker.json

+1 −1
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ 
    {

      "name": "HELM_DEPLOY_ARGS",

      "description": "The Helm [command with options](https://helm.sh/docs/helm/helm_upgrade/) to deploy the application (_without dynamic arguments such as release name and chart_)",

      "default": "upgrade --install --atomic --timeout 120s",

      "default": "upgrade --install --rollback-on-failure --timeout 120s",

      "advanced": true

    },

    {

templates/gitlab-ci-helm.yml

+1 −1
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ spec: 
      default: ''

    deploy-args:

      description: The Helm [command with options](https://helm.sh/docs/helm/helm_upgrade/) to deploy the application (_without dynamic arguments such as release name and chart_)

      default: upgrade --install --atomic --timeout 120s

      default: upgrade --install --rollback-on-failure --timeout 120s

    delete-args:

      description: The Helm [command with options](https://helm.sh/docs/helm/helm_uninstall/) to cleanup the application (_without dynamic arguments such as release name_)

      default: uninstall