Commit 2f6c0203 authored by Pierre Smeyers's avatar Pierre Smeyers
Browse files

fix(ci-lint): golangci-lint V2 no longer support 'goimports' as a linter, but as formatter

parent d645607c

README.md

+1 −1
Original line number Diff line number Diff line
@@ -164,7 +164,7 @@ It is bound to the `build` stage, and uses the following variables: 
| Input / Variable | Description                                                                                              | Default value                          |

|-----------------------|----------------------------------------------------------------------------------------------------------|----------------------------------------|

| `ci-lint-image` / `GO_CI_LINT_IMAGE` | The Docker image used to run `golangci-lint`                                                             | `registry.hub.docker.com/golangci/golangci-lint:latest-alpine` <br/>[![Trivy Badge](https://to-be-continuous.gitlab.io/doc/secu/trivy-badge-GO_CI_LINT_IMAGE.svg)](https://to-be-continuous.gitlab.io/doc/secu/trivy-GO_CI_LINT_IMAGE) |

| `ci-lint-args` / `GO_CI_LINT_ARGS` | `golangci-lint` [command line arguments](https://github.com/golangci/golangci-lint#command-line-options) | `-E gosec,goimports ./...`             |

| `ci-lint-args` / `GO_CI_LINT_ARGS` | `golangci-lint` [command line arguments](https://github.com/golangci/golangci-lint#command-line-options) | `-E gosec ./...`             |

| `ci-lint-disabled` / `GO_CI_LINT_DISABLED` | Set to `true` to disable this job                                                                        | _none_ (enabled)                        |



In addition to a textual report in the console, this job produces the following reports, kept for one day:

kicker.json

+1 −1
Original line number Diff line number Diff line
@@ -116,7 +116,7 @@ 
        {

          "name": "GO_CI_LINT_ARGS",

          "description": "`golangci-lint` [command line arguments](https://github.com/golangci/golangci-lint#command-line-options)",

          "default": "-E gosec,goimports ./...",

          "default": "-E gosec ./...",

          "advanced": true

        }

      ]

templates/gitlab-ci-golang.yml

+1 −1
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ spec: 
      default: registry.hub.docker.com/golangci/golangci-lint:latest-alpine

    ci-lint-args:

      description: '`golangci-lint` [command line arguments](https://github.com/golangci/golangci-lint#command-line-options)'

      default: -E gosec,goimports ./...

      default: -E gosec ./...

    semgrep-image:

      description: The Docker image used to run [Semgrep](https://semgrep.dev/docs/)

      default: registry.hub.docker.com/semgrep/semgrep:latest