Commit cf3b634e authored by Pierre Smeyers's avatar Pierre Smeyers
Browse files

fix(publish): fix multiple publish args 

$NG_PUBLISH_ARGS was surronded by double quotes, thus preventing word splitting in cas of multiple options and words
parent f66f61b3

templates/gitlab-ci-angular.yml

+9 −34
Original line number Diff line number Diff line
@@ -136,43 +136,23 @@ workflow: 
variables:

  # variabilized tracking image

  TBC_TRACKING_IMAGE: registry.gitlab.com/to-be-continuous/tools/tracking:master



  # Default ng workspace

  NG_WORKSPACE_DIR: $[[ inputs.workspace-dir ]]



  # Default Docker image for ANGULAR CLI (can be overridden)

  NG_CLI_IMAGE: $[[ inputs.cli-image ]]



  # Angular lint

  NG_LINT_ARGS: $[[ inputs.lint-args ]]



  # Angular test

  NG_TEST_ARGS: $[[ inputs.test-args ]]



  NG_E2E_ARGS: $[[ inputs.e2e-args ]]



  NG_AUDIT_DISABLED: $[[ inputs.audit-disabled ]]



  NG_AUDIT_ARGS: $[[ inputs.audit-args ]]



  NG_OUTDATED_DISABLED: $[[ inputs.outdated-disabled ]]



  NG_OUTDATED_ALLOW_FAILURE: $[[ inputs.outdated-allow-failure ]]

  

  NG_OUTDATED_ARGS: $[[ inputs.outdated-args ]]



  # Angular Build

  NG_BUILD_ARGS: $[[ inputs.build-args ]]



  NG_SBOM_OPTS: $[[ inputs.sbom-opts ]]



  # default production ref name (pattern)

  PROD_REF: '/^(master|main)$/'

  # default integration ref name (pattern)

  INTEG_REF: '/^develop$/'

  # default release tag name (pattern)

  RELEASE_REF: '/^v?[0-9]+\.[0-9]+\.[0-9]+(-[a-zA-Z0-9-\.]+)?(\+[a-zA-Z0-9-\.]+)?$/'



  NPM_CONFIG_REGISTRY: $[[ inputs.npm-config-registry ]]

  NPM_CONFIG_SCOPED_REGISTRIES: $[[ inputs.npm-config-scoped-registries ]]

  NG_INSTALL_EXTRA_OPTS: $[[ inputs.install-extra-opts ]]
@@ -184,18 +164,12 @@ variables: 
  NG_SBOM_DISABLED: $[[ inputs.sbom-disabled ]]

  NG_SBOM_VERSION: $[[ inputs.sbom-version ]]



  # ==================================================

  # Variables for publication

  # ==================================================



  # NG_PUBLISH_ENABLED



  # List of projects to publish, use space (" ") for separation

  # ex: NG_PUBLISH_PROJECTS: "Project1 Project2 myLib"

  # If no projects specified, all workspace projects are published.



  # Set some args of `npm publish` command

  # ex: NG_PUBLISH_ARGS: "--dry-run"

  # default production ref name (pattern)

  PROD_REF: '/^(master|main)$/'

  # default integration ref name (pattern)

  INTEG_REF: '/^develop$/'

  # default release tag name (pattern)

  RELEASE_REF: '/^v?[0-9]+\.[0-9]+\.[0-9]+(-[a-zA-Z0-9-\.]+)?(\+[a-zA-Z0-9-\.]+)?$/'

  

# ==================================================

# Stages definition
@@ -631,7 +605,8 @@ stages: 
      fi



      log_info "Publishing project '${project}' from ${projectOutputDir}"

      npm publish ${TRACE+--verbose} "${projectOutputDir}" "${NG_PUBLISH_ARGS}"

      # shellcheck disable=SC2086

      npm publish ${TRACE+--verbose} "${projectOutputDir}" ${NG_PUBLISH_ARGS}

    done

  }