Commit 67efe308 authored by Pierre Smeyers's avatar Pierre Smeyers
Browse files

Merge branch 'fix/ng-build-no-progress-argument' into 'master' 

fix: move --no-progress to build args

Closes #35

See merge request to-be-continuous/angular!73
parents 88b1708a ff049702

README.md

+1 −1
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ Those stage are bound to the `build` stage, and uses the following variable: 
| Input / Variable               | Description                                                | Default value                                                                 |

| ------------------------------ | ---------------------------------------------------------- | ----------------------------------------------------------------------------- |

| `test-args` / `NG_TEST_ARGS`   | Angular [ng test](https://angular.io/cli/test) arguments   | `test --code-coverage --reporters progress,junit --watch=false --no-progress` |

| `build-args` / `NG_BUILD_ARGS` | Angular [ng build](https://angular.io/cli/build) arguments | `build`                                                                       |

| `build-args` / `NG_BUILD_ARGS` | Angular [ng build](https://angular.io/cli/build) arguments | `build --no-progress`                                                         |



The next chapters presents some requirements related to your unit tests (using Karma).

kicker.json

+1 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ 
    {

      "name": "NG_BUILD_ARGS",

      "description": "Angular [ng build](https://angular.io/cli/build) arguments",

      "default": "build",

      "default": "build --no-progress",

      "advanced": true

    },

    {

templates/gitlab-ci-angular.yml

+2 −2
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ spec: 
      default: ''

    build-args:

      description: Angular [ng build](https://angular.io/cli/build) arguments

      default: build

      default: build --no-progress 

    test-args:

      description: Angular [ng test](https://angular.io/cli/test) arguments

      default: test --code-coverage --reporters progress,junit --watch=false --no-progress
@@ -464,7 +464,7 @@ stages: 
      for app in ${apps}; do

        log_debug "building application ${app}"

        # shellcheck disable=SC2086

        ng ${NG_BUILD_ARGS} --no-progress "${app}"

        ng ${NG_BUILD_ARGS} "${app}"

      done

    fi

  }