Unverified Commit 1b5806bf authored by Kroese's avatar Kroese Committed by GitHub
Browse files

feat: Print warning based on OS (#495)

parent 9a416971

src/network.sh

+23 −0
Original line number Diff line number Diff line
@@ -244,6 +244,23 @@ closeNetwork() { 
  return 0

}



checkOS() {



  local name

  local os=""

  name=$(uname -a)



  [[ "${name,,}" == *"darwin"* ]] && os="MacOS"

  [[ "${name,,}" == *"microsoft"* ]] && os="Windows"



  if [ -n "$os" ]; then

    error "You are using Docker Desktop for $os which does not support macvlan, please revert to bridge networking!"

    return 1

  fi



  return 0

}



getInfo() {



  if [ -z "$VM_NET_DEV" ]; then
@@ -305,6 +322,8 @@ fi 


if [[ "$DHCP" == [Yy1]* ]]; then



  ! checkOS && exit 19



  if [[ "$GATEWAY" == "172."* ]]; then

    warn "your gateway IP starts with 172.* which is often a sign that you are not on a macvlan network (required for DHCP)!"

  fi
@@ -314,6 +333,10 @@ if [[ "$DHCP" == [Yy1]* ]]; then 


else



  if [[ "$GATEWAY" != "172."* ]]; then

    ! checkOS && exit 19

  fi



  # Configuration for static IP

  configureNAT

src/proc.sh

+7 −3
Original line number Diff line number Diff line
@@ -31,10 +31,14 @@ if [[ "$KVM" != [Nn]* ]]; then 


  if [ -n "$KVM_ERR" ]; then

    KVM="N"

    if [[ "$OSTYPE" =~ ^darwin ]]; then

      warn "you are using MacOS which has no KVM support, this will cause a major loss of performance."

    else

      error "KVM acceleration not available $KVM_ERR, this will cause a major loss of performance."

      error "See the FAQ on how to enable it, or continue without KVM by setting KVM=N (not recommended)."

      [[ "$DEBUG" != [Yy1]* ]] && exit 88

    fi

  fi



fi

src/reset.sh

+0 −1
Original line number Diff line number Diff line
@@ -17,7 +17,6 @@ echo "❯ For support visit $SUPPORT" 


: "${BOOT:=""}"           # URL of the ISO file

: "${DEBUG:="N"}"         # Disable debugging

: "${CONSOLE:="N"}"       # Disable console

: "${MACHINE:="q35"}"     # Machine selection

: "${ALLOCATE:=""}"       # Preallocate diskspace

: "${ARGUMENTS:=""}"      # Extra QEMU parameters